Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 )
Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) ...................................................................... Patch Set 3: (15 comments) http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc File be/src/exprs/conditional-functions.cc: http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@33 PS3, Line 33: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@36 PS3, Line 36: /// %1 = trunc i16 %0 to i8 line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@39 PS3, Line 39: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@44 PS3, Line 44: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@45 PS3, Line 45: /// return_else: ; preds = %eval_condition, %is_condition_null line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@110 PS3, Line 110: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@116 PS3, Line 116: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@119 PS3, Line 119: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@124 PS3, Line 124: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@180 PS3, Line 180: if (UNLIKELY(*fn == nullptr)) return Status(TErrorCode::IR_VERIFY_FAILED, "CoalesceExpr"); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@188 PS3, Line 188: /// %first_value = call { i8, i64 } @GetSlotRef(%"class.impala::ScalarExprEvaluator"* %eval, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@193 PS3, Line 193: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@195 PS3, Line 195: /// ret { i8, i64 } %first_value line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@196 PS3, Line 196: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16208/3/be/src/exprs/conditional-functions.cc@198 PS3, Line 198: /// %second_value = call { i8, i64 } @Literal(%"class.impala::ScalarExprEvaluator"* %eval, line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f617a9148492ccafb46112ce0af103a10090f8 Gerrit-Change-Number: 16208 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 18 Jul 2020 08:49:19 +0000 Gerrit-HasComments: Yes
