Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 )
Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16208/4/be/src/exprs/conditional-functions.cc File be/src/exprs/conditional-functions.cc: http://gerrit.cloudera.org:8080/#/c/16208/4/be/src/exprs/conditional-functions.cc@23 PS4, Line 23: // TODO: Do we need this comment? Do you think we should have this comment? -- To view, visit http://gerrit.cloudera.org:8080/16208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f617a9148492ccafb46112ce0af103a10090f8 Gerrit-Change-Number: 16208 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 20 Jul 2020 15:00:02 +0000 Gerrit-HasComments: Yes
