Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16303 )
Change subject: IMPALA-10050: Fixed DCHECK error for backend in terminal state. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16303/2/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/16303/2/be/src/runtime/query-state.cc@804 PS2, Line 804: DCHECK_EQ(is_cancelled_.Load(), 1); Since you looked into it, could you add a brief comment here about why this DCHECK is correct. If I understand correctly, it's something like: If the query hit an error, when the final status report is sent the coordinator's response will instruct the QueryState to cancel itself, so Cancel() should have always been called by this point. -- To view, visit http://gerrit.cloudera.org:8080/16303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba6a72f98c0f9299c22c58830ec5a643335b966a Gerrit-Change-Number: 16303 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 10 Aug 2020 17:00:41 +0000 Gerrit-HasComments: Yes
