Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16303 )
Change subject: IMPALA-10050: Fixed DCHECK error for backend in terminal state. ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/16303/5/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/16303/5/be/src/runtime/coordinator-backend-state.cc@413 PS5, Line 413: if (ShouldExecStatusReportBeSkipped()) return false; I'm concerned that this doesn't work as it violates the invariant described in the comment above, i.e. that once IsDone() is true we shouldn't update the profile any more to prevent a potential race with ComputeQuerySummary(). I suspect instead that we want to make changes in Coordinator so that when we hit this case we don't apply the profile update but we still return CANCELLED. http://gerrit.cloudera.org:8080/#/c/16303/5/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: http://gerrit.cloudera.org:8080/#/c/16303/5/be/src/runtime/query-exec-mgr.cc@229 PS5, Line 229: ExecEnv::GetInstance()->query_exec_mgr()->qs_map_.DoFuncForAllEntries( What's the reason for this change? -- To view, visit http://gerrit.cloudera.org:8080/16303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba6a72f98c0f9299c22c58830ec5a643335b966a Gerrit-Change-Number: 16303 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 24 Aug 2020 20:15:29 +0000 Gerrit-HasComments: Yes
