Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16303 )
Change subject: IMPALA-10050: Fixed DCHECK error for backend in terminal state. ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/16303/6/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/16303/6/be/src/runtime/coordinator-backend-state.h@138 PS6, Line 138: oveall > overall Fixed http://gerrit.cloudera.org:8080/#/c/16303/6/be/src/runtime/coordinator-backend-state.h@151 PS6, Line 151: Returns true iff this update changed IsDone() > needs to be updated Fixed http://gerrit.cloudera.org:8080/#/c/16303/6/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/16303/6/be/src/runtime/coordinator.cc@915 PS6, Line 915: // This backend execution has completed. > Lets update this to say something like 'This report caused this backend to fixed http://gerrit.cloudera.org:8080/#/c/16303/6/be/src/runtime/coordinator.cc@1000 PS6, Line 1000: backend_state->GetStatus().ok() || result.report_applied > I think it might be better if this is '!result.backend_done' If result.backend_done equal true, that means the backend is done, but other backends maybe still running. If one backend is completed successfully, e.g. backend status is OK and result.backend_done is true, we will not update overall exec_state here and IsExecuting() is true. In this case, we should return OK so we cannot use !result.backend_done. -- To view, visit http://gerrit.cloudera.org:8080/16303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba6a72f98c0f9299c22c58830ec5a643335b966a Gerrit-Change-Number: 16303 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Aug 2020 23:00:33 +0000 Gerrit-HasComments: Yes
