Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16303 )
Change subject: IMPALA-10050: Fixed DCHECK error for backend in terminal state. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16303/2/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/16303/2/be/src/runtime/query-state.cc@391 PS2, Line 391: // Don't retry if the coordinator is not active. > nit: could you move this line down to directly above the "if ... break;" li fixed it. http://gerrit.cloudera.org:8080/#/c/16303/2/be/src/runtime/query-state.cc@804 PS2, Line 804: DCHECK_EQ(is_cancelled_.Load(), 1); > Since you looked into it, could you add a brief comment here about why this Added comments. -- To view, visit http://gerrit.cloudera.org:8080/16303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba6a72f98c0f9299c22c58830ec5a643335b966a Gerrit-Change-Number: 16303 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 10 Aug 2020 17:16:50 +0000 Gerrit-HasComments: Yes
