Wenzhe Zhou has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16303 )
Change subject: IMPALA-10050: Fixed DCHECK error for backend in terminal state. ...................................................................... IMPALA-10050: Fixed DCHECK error for backend in terminal state. Recent patch for IMPALA-6788 makes coordinator to cancel inflight query fragment instances when it receives failure report from one backend. It's possible the BackendState::Cancel() is called for one fragment instance before the first execution status report from its backend is received and processed by the coordinator. Since the status of BackendState is set as Cancelled after Cancel() is called, the execution of the fragment instance is treated as Done in such case so that the status report will NOT be processed. Hence the backend receives response OK from coordinator even it sent a report with execution error. This make backend hit DCHECK error if backend in the terminal state with error. This patch fixs the issue by making coordinator send CANCELLED status in the response of status report if the backend status is not ok and the execution status report is not applied. Testing: - The issue could be reproduced by running test_failpoints for about 20 iterations. Verified the fixing by running test_failpoints over 200 iterations without DCHECK failure. - Passed TestProcessFailures::test_kill_coordinator. - Psssed TestRPCException::test_state_report_error. - Passed exhaustive tests. Change-Id: Iba6a72f98c0f9299c22c58830ec5a643335b966a --- M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/coordinator-backend-state.h M be/src/runtime/coordinator.cc M be/src/runtime/query-exec-mgr.cc M be/src/runtime/query-state.cc 5 files changed, 48 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/16303/7 -- To view, visit http://gerrit.cloudera.org:8080/16303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iba6a72f98c0f9299c22c58830ec5a643335b966a Gerrit-Change-Number: 16303 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
