Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16503 )
Change subject: IMPALA-9952: Fix page index filtering for empty pages ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16503/2/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/16503/2/be/src/exec/parquet/hdfs-parquet-scanner.cc@824 PS2, Line 824: filter_pages_ = false; this is not needed, as we set it to false in ResetPageFiltering() anyway http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/parquet-common.cc File be/src/exec/parquet/parquet-common.cc: http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/parquet-common.cc@172 PS1, Line 172: int next_page_idx = page_idx + 1; : while (next_page_idx < page_locations.size() && : page_locations[next_page_idx].compressed_page_size == 0) { : > Yeah it'd also work, but I didn't want to dynamically allocate a new vector I don't think that copying a vector with the size of the number of pages would matter, but I am ok with the current solution if you prefer it. -- To view, visit http://gerrit.cloudera.org:8080/16503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4db493fc7c383ed5ef492da29c9b15eeb3d17bb0 Gerrit-Change-Number: 16503 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2020 14:46:45 +0000 Gerrit-HasComments: Yes
