Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16503 )
Change subject: IMPALA-9952: Fix page index filtering for empty pages ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16503/2/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/16503/2/be/src/exec/parquet/hdfs-parquet-scanner.cc@824 PS2, Line 824: if (!ComputeCandidatePages(page_locations, candidate_ranges_, row_group.num_rows, > this is not needed, as we set it to false in ResetPageFiltering() anyway Done http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/parquet-common.cc File be/src/exec/parquet/parquet-common.cc: http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/parquet-common.cc@172 PS1, Line 172: while (next_page_idx < page_locations.size() && : page_locations[next_page_idx].compressed_page_size == 0) { : ++next_page_idx; : } > I don't think that copying a vector with the size of the number of pages wo Yeah, for now I'd rather leave it that way. -- To view, visit http://gerrit.cloudera.org:8080/16503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4db493fc7c383ed5ef492da29c9b15eeb3d17bb0 Gerrit-Change-Number: 16503 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Oct 2020 15:03:07 +0000 Gerrit-HasComments: Yes
