Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16503 )
Change subject: IMPALA-9952: Fix page index filtering for empty pages ...................................................................... Patch Set 2: (5 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/16503/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16503/1//COMMIT_MSG@11 PS1, Line 11: data > typo: data Done http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/hdfs-parquet-scanner.cc@637 PS1, Line 637: if (filter_pages_ && candidate_ranges_.empty()) { > nit: extra line Done http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/hdfs-parquet-scanner.cc@724 PS1, Line 724: ETURN_IF_ERR > Maybe make filter_pages a member, and reset it in ResetPageFiltering? Done http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/parquet-common.cc File be/src/exec/parquet/parquet-common.cc: http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/parquet-common.cc@142 PS1, Line 142: auto& last_valid_page = page_locations[last_valid_idx]; : > can you add some comment in this block? e.g. first_row_index must have prog Done http://gerrit.cloudera.org:8080/#/c/16503/1/be/src/exec/parquet/parquet-common.cc@172 PS1, Line 172: int next_page_idx = page_idx + 1; : while (next_page_idx < page_locations.size() && : page_locations[next_page_idx].compressed_page_size == 0) { : > I may have missed something, but wouldn't it be simpler to create a copy of Yeah it'd also work, but I didn't want to dynamically allocate a new vector and copy integers. Though I didn't measure what would be the actual overhead. -- To view, visit http://gerrit.cloudera.org:8080/16503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4db493fc7c383ed5ef492da29c9b15eeb3d17bb0 Gerrit-Change-Number: 16503 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2020 13:40:00 +0000 Gerrit-HasComments: Yes
