wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 )
Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Thanks for new feature! http://gerrit.cloudera.org:8080/#/c/17012/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17012/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@175 PS1, Line 175: append Maybe we can define this var as 'final'. http://gerrit.cloudera.org:8080/#/c/17012/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@192 PS1, Line 192: replace Same to above -- To view, visit http://gerrit.cloudera.org:8080/17012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf4acfb54cf62a3f3b2e8db9d04044580151299c Gerrit-Change-Number: 17012 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 02 Feb 2021 12:33:17 +0000 Gerrit-HasComments: Yes
