Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 )
Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17012/2/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: http://gerrit.cloudera.org:8080/#/c/17012/2/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@552 PS2, Line 552: if (overwrite_) validateNoBucketTransform((FeIcebergTable)table_); : validateIcebergColumnsForInsert((FeIcebergTable)table_); : } > nit: I think this fits into one line Done http://gerrit.cloudera.org:8080/#/c/17012/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17012/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@169 PS2, Line 169: private static interface BatchWrite { > Just thinking out loud: would it make sense to make this a generic base cla We could also have a reference to the common interface of AppendFiles and ReplacePartitions and invoke commit in BatchWrite.commit() via this reference. But the current code is quite simple and straightforward so I'm not sure if it worth the trouble. http://gerrit.cloudera.org:8080/#/c/17012/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test: http://gerrit.cloudera.org:8080/#/c/17012/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test@115 PS2, Line 115: AnalysisException: The Iceberg table has BUCKET partitioning. > Ah, indeed. Thanks for the explanation! Let's leave it as it is then. Done -- To view, visit http://gerrit.cloudera.org:8080/17012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf4acfb54cf62a3f3b2e8db9d04044580151299c Gerrit-Change-Number: 17012 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 04 Feb 2021 15:57:44 +0000 Gerrit-HasComments: Yes
