Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 )
Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/17012/2/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: http://gerrit.cloudera.org:8080/#/c/17012/2/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@552 PS2, Line 552: if (overwrite_) { : validateNoBucketTransform((FeIcebergTable)table_); : } nit: I think this fits into one line http://gerrit.cloudera.org:8080/#/c/17012/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17012/2/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@169 PS2, Line 169: private static interface BatchWrite { Just thinking out loud: would it make sense to make this a generic base class that accepts either an AppendFiles or a ReplacePartitions as a template param and then the commit() function could also be implemented in the base class. This comment isn't important by any means just wondering. http://gerrit.cloudera.org:8080/#/c/17012/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test: http://gerrit.cloudera.org:8080/#/c/17012/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test@115 PS2, Line 115: AnalysisException: The Iceberg table has BUCKET partitioning. > This is only the first sentence of the error message. The actual error mess Ah, indeed. Thanks for the explanation! Let's leave it as it is then. -- To view, visit http://gerrit.cloudera.org:8080/17012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf4acfb54cf62a3f3b2e8db9d04044580151299c Gerrit-Change-Number: 17012 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 04 Feb 2021 13:36:46 +0000 Gerrit-HasComments: Yes
