Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 )
Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables ...................................................................... Patch Set 2: (1 comment) I have checked the tests so far and the patch look good for me. I only have a minor suggestion. Will check the rest of the patch tomorrow. http://gerrit.cloudera.org:8080/#/c/17012/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test: http://gerrit.cloudera.org:8080/#/c/17012/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test@115 PS2, Line 115: AnalysisException: The Iceberg table has BUCKET partitioning. I think including the fact that this was in INERT OVERWRITE in the error message would help the user experiance a bit. E.g.: "INSERT OVERWRITE is not supported for Iceberg tables that have BUCKET partitioning." -- To view, visit http://gerrit.cloudera.org:8080/17012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf4acfb54cf62a3f3b2e8db9d04044580151299c Gerrit-Change-Number: 17012 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Wed, 03 Feb 2021 16:35:25 +0000 Gerrit-HasComments: Yes
