Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17166
Change subject: IMPALA-10565: Check max_spilled_result_spooling_mem vs scratch_limit ...................................................................... IMPALA-10565: Check max_spilled_result_spooling_mem vs scratch_limit IMPALA-9856 enables result spooling by default. However, if the query option scratch_limit is set lower than max_spilled_result_spooling_mem, the query might fail in the middle of execution due to insufficient scratch space. This patch validation that when result spooling is enabled, max_spilled_result_spooling_mem <= scratch_limit. This patch also fix validation between max_result_spooling_mem and max_spilled_result_spooling_mem that should treat both value 0 and -1 as unbounded. Testing: - Lower max_spilled_result_spooling_mem in test_with_high_scratch_limit and test_with_low_scratch_limit. - Toggle off spool_query_results in test_with_zero_scratch_limit_no_memory_limit to ensure that spill will not happen. - Add test_with_scratch_limit_less_than_max_spilled_result_spooling_mem. - Add be test QueryOptions.ResultSpoolingWithScratchLimit. - Pass exhaustive tests. Change-Id: I541f46e6911694e14c0fc25be1a6982fd929d3a9 --- M be/src/service/query-options-test.cc M be/src/service/query-options.cc M tests/query_test/test_scratch_limit.py 3 files changed, 120 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/17166/1 -- To view, visit http://gerrit.cloudera.org:8080/17166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I541f46e6911694e14c0fc25be1a6982fd929d3a9 Gerrit-Change-Number: 17166 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
