Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 )
Change subject: IMPALA-10565: Check max_spilled_result_spooling_mem vs scratch_limit ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17166/1/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/17166/1/be/src/service/query-options.cc@1111 PS1, Line 1111: $1 > slightly misleading,does not necessarily have to be the same, could be 0 or Agree. I will rephrase into this: "If max_result_spooling_mem is set to unbounded ($0) max_spilled_result_spooling_mem must be set to unbounded (0 or -1) as well." http://gerrit.cloudera.org:8080/#/c/17166/1/be/src/service/query-options.cc@1124 PS1, Line 1124: if (query_options->spool_query_results && scratch_limit != -1) { > since now we have spilling on by default, spool_query_results is set to 1GB Good point. Quick git grep show some more places where scratch_limit is set to 0, like some in spilling-naaj-no-deny-reservation.test. I will also set spool_query_results=0 in these places. -- To view, visit http://gerrit.cloudera.org:8080/17166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I541f46e6911694e14c0fc25be1a6982fd929d3a9 Gerrit-Change-Number: 17166 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 10 Mar 2021 23:28:30 +0000 Gerrit-HasComments: Yes
