Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 )
Change subject: IMPALA-10565: Check max_spilled_result_spooling_mem vs scratch_limit ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17166/1/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/17166/1/be/src/service/query-options.cc@1111 PS1, Line 1111: $1 slightly misleading,does not necessarily have to be the same, could be 0 or -1, right? http://gerrit.cloudera.org:8080/#/c/17166/1/be/src/service/query-options.cc@1124 PS1, Line 1124: if (query_options->spool_query_results && scratch_limit != -1) { since now we have spilling on by default, spool_query_results is set to 1GB, i wonder if this check will break older workloads that set the scratch limit to something and dont expect it to throw an error. -- To view, visit http://gerrit.cloudera.org:8080/17166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I541f46e6911694e14c0fc25be1a6982fd929d3a9 Gerrit-Change-Number: 17166 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 10 Mar 2021 21:54:31 +0000 Gerrit-HasComments: Yes
