Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 )
Change subject: IMPALA-10565: Check max_spilled_result_spooling_mem vs scratch_limit ...................................................................... Patch Set 2: (2 comments) Patch set 2 disable result spooling in tests that set scratch_limit > -1. http://gerrit.cloudera.org:8080/#/c/17166/1/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/17166/1/be/src/service/query-options.cc@1111 PS1, Line 1111: un > Agree. I will rephrase into this: Done http://gerrit.cloudera.org:8080/#/c/17166/1/be/src/service/query-options.cc@1124 PS1, Line 1124: if (query_options->spool_query_results && scratch_limit != -1) { > Good point. Quick git grep show some more places where scratch_limit is set Done -- To view, visit http://gerrit.cloudera.org:8080/17166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I541f46e6911694e14c0fc25be1a6982fd929d3a9 Gerrit-Change-Number: 17166 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 11 Mar 2021 00:53:54 +0000 Gerrit-HasComments: Yes
