Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17168 )
Change subject: IMPALA-10564: Return error when inserting an invalid decimal value ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/17168/7/be/src/exec/hdfs-text-table-writer.cc File be/src/exec/hdfs-text-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/17168/7/be/src/exec/hdfs-text-table-writer.cc@112 PS7, Line 112: state_->GetQueryStatus().IsInvalidDecimalError() > Probably want to move this check to after the check if the column has decim Done http://gerrit.cloudera.org:8080/#/c/17168/7/be/src/udf/udf.h File be/src/udf/udf.h: http://gerrit.cloudera.org:8080/#/c/17168/7/be/src/udf/udf.h@29 PS7, Line 29: #include "gen-cpp/ErrorCodes_types.h" // for TErrorCode > I'm not sure if you can do this. See the comment a few lines above this - t How about use "#ifndef IMPALA_UDF_SDK_BUILD" to include this file? Otherwise, just pass the string. This is used in udf.cc. http://gerrit.cloudera.org:8080/#/c/17168/7/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/17168/7/common/thrift/ImpalaService.thrift@652 PS7, Line 652: false by default > I think this is a different situation than the constant decimal case, since If we set the default value for query option as true, the default behavior for the cases with constant decimal will be changed. -- To view, visit http://gerrit.cloudera.org:8080/17168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64ce4ed194af81ef06401ffc1124e12f05b8da98 Gerrit-Change-Number: 17168 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sat, 20 Mar 2021 00:11:26 +0000 Gerrit-HasComments: Yes
