Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17168 )
Change subject: IMPALA-10564: Return error when inserting an invalid decimal value ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/17168/7/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/17168/7/common/thrift/ImpalaService.thrift@652 PS7, Line 652: false by default > I think this is a different situation than the constant decimal case, since It is a fair point to keep the default behavior same as before even though it is not right..as users may get surprised if some of the big insert-select or CTAS jobs start failing. Once we socialize this with the user base some more, we could decide to change the default. The ideal solution of course is to do the row skipping as discussed in the jira but that is non-trivial. BTW, Wenzhe, my understanding is the alias is not required to repro the issue ..if the columns in the source table are defined with decimal(28,10). e.g 3 columns a, b, c each of decimal(28,10). Then if we do 'create table target as select cast(a*b*c as decimal(28,10)) from source' that could still overflow depending on the actual values of a, b, c. -- To view, visit http://gerrit.cloudera.org:8080/17168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64ce4ed194af81ef06401ffc1124e12f05b8da98 Gerrit-Change-Number: 17168 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sat, 20 Mar 2021 00:28:44 +0000 Gerrit-HasComments: Yes
