Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17168 )
Change subject: IMPALA-10564: Return error when inserting an invalid decimal value ...................................................................... Patch Set 7: > Patch Set 7: > > (1 comment) > It is not like the intended behavior by design. Instead, it's more like a bug > that RuntimeState::CheckQueryState() is not called in a corner case. This does seem to be the underlying issue right ? Is this why when you set ABORT_ON_ERROR = true, the error was not propagated back to caller ? If we can fix this behavior, then yes I would agree we don't need to introduce a new query option. -- To view, visit http://gerrit.cloudera.org:8080/17168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64ce4ed194af81ef06401ffc1124e12f05b8da98 Gerrit-Change-Number: 17168 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 22 Mar 2021 16:25:12 +0000 Gerrit-HasComments: No
