Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17168 )
Change subject: IMPALA-10564: Return error when inserting an invalid decimal value ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/17168/7/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/17168/7/common/thrift/ImpalaService.thrift@652 PS7, Line 652: false by default > As I mentioned in the above comments, FE evaluates the constant decimal exp According to document https://impala.apache.org/docs/build/html/topics/impala_decimal.html, the Overflow behavior for DECIMAL_V2 should be "Aborts with an error". I lean to remove the new query option. -- To view, visit http://gerrit.cloudera.org:8080/17168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64ce4ed194af81ef06401ffc1124e12f05b8da98 Gerrit-Change-Number: 17168 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 22 Mar 2021 03:48:52 +0000 Gerrit-HasComments: Yes
