Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17244 )
Change subject: IMPALA-10613 : Standup HMS thrift server in Catalog ...................................................................... Patch Set 1: (81 comments) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java File fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java: http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@118 PS1, Line 118: GetPartialCatalogObjectRequestBuilder reqBuilder = new GetPartialCatalogObjectRequestBuilder() line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@219 PS1, Line 219: GetPartialCatalogObjectRequestBuilder catalogReq = new GetPartialCatalogObjectRequestBuilder() line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@504 PS1, Line 504: + "fallback path. Time taken: {} msec", getPartsResult.getPartitionsSize(), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@508 PS1, Line 508: + "fallback path. Time taken: {} msec", getPartsResult.getPartitionsSize(), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3397 PS1, Line 3397: TGetPartialCatalogObjectRequest req, String tableLoadReason) throws CatalogException { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@745 PS1, Line 745: new ParallelFileMetadataLoader(getFileSystem(), partBuilders, validWriteIds_, validTxnList, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@746 PS1, Line 746: Utils.shouldRecursivelyListPartitions(this), getHostIndex(), debugActions, logPrefix) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java: http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java@199 PS1, Line 199: new Class[]{ThriftHiveMetastore.Iface.class, ICatalogMetastoreServer.class}, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@277 PS1, Line 277: * APIs that should be served from CatalogD must be overridden in {@link CatalogMetastoreServer}. line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@291 PS1, Line 291: protected static final String METAEXCEPTION_MSG_FORMAT = "Unexpected error occurred while" line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@416 PS1, Line 416: return client.getHiveClient().getThriftClient().get_database_req(getDatabaseRequest); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@521 PS1, Line 521: throws AlreadyExistsException, InvalidObjectException, MetaException, NoSuchObjectException, TException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@530 PS1, Line 530: throws AlreadyExistsException, InvalidObjectException, MetaException, NoSuchObjectException, TException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@544 PS1, Line 544: throws AlreadyExistsException, InvalidObjectException, MetaException, NoSuchObjectException, TException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@554 PS1, Line 554: throws AlreadyExistsException, InvalidObjectException, MetaException, NoSuchObjectException, TException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@608 PS1, Line 608: client.getHiveClient().getThriftClient().add_default_constraint(addDefaultConstraintRequest); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@616 PS1, Line 616: client.getHiveClient().getThriftClient().add_check_constraint(addCheckConstraintRequest); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@652 PS1, Line 652: return client.getHiveClient().getThriftClient().truncate_table_req(truncateTableRequest); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@824 PS1, Line 824: public void alter_table_with_environment_context(String dbname, String tblName, Table table, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@828 PS1, Line 828: client.getHiveClient().getThriftClient().alter_table_with_environment_context(dbname, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@834 PS1, Line 834: public void alter_table_with_cascade(String dbname, String tblName, Table table, boolean cascade) line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@903 PS1, Line 903: public Partition append_partition_with_environment_context(String dbname, String tblname, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@908 PS1, Line 908: .append_partition_with_environment_context(dbname, tblname, partVals, environmentContext); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@934 PS1, Line 934: public boolean drop_partition(String dbname, String tblanme, List<String> partVals, boolean deleteData) line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@937 PS1, Line 937: return client.getHiveClient().getThriftClient().drop_partition(dbname, tblanme, partVals, deleteData); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@953 PS1, Line 953: public boolean drop_partition_by_name(String dbname, String tblname, String partName, boolean deleteData) line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@996 PS1, Line 996: throws MetaException, NoSuchObjectException, InvalidObjectException, InvalidInputException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1008 PS1, Line 1008: throws MetaException, NoSuchObjectException, InvalidObjectException, InvalidInputException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1186 PS1, Line 1186: public GetPartitionNamesPsResponse get_partition_names_ps_req(GetPartitionNamesPsRequest req) line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1195 PS1, Line 1195: public GetPartitionsPsWithAuthResponse get_partitions_ps_with_auth_req(GetPartitionsPsWithAuthRequest req) line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1267 PS1, Line 1267: String tblName = getPartitionsByNamesRequest.getDb_name() + "." + getPartitionsByNamesRequest.getTbl_name(); line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1296 PS1, Line 1296: .getValidWriteIdListFromString(getPartitionsByNamesRequest.getValidWriteIdList()); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1408 PS1, Line 1408: throws MetaException, NoSuchObjectException, UnknownDBException, UnknownTableException, UnknownPartitionException, InvalidPartitionException, TException { line too long (160 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1418 PS1, Line 1418: throws MetaException, NoSuchObjectException, UnknownDBException, UnknownTableException, UnknownPartitionException, InvalidPartitionException, TException { line too long (160 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1485 PS1, Line 1485: throws NoSuchObjectException, InvalidObjectException, MetaException, InvalidInputException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1494 PS1, Line 1494: throws NoSuchObjectException, InvalidObjectException, MetaException, InvalidInputException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1504 PS1, Line 1504: throws NoSuchObjectException, InvalidObjectException, MetaException, InvalidInputException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1514 PS1, Line 1514: throws NoSuchObjectException, InvalidObjectException, MetaException, InvalidInputException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1523 PS1, Line 1523: throws NoSuchObjectException, MetaException, InvalidInputException, InvalidObjectException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1533 PS1, Line 1533: throws NoSuchObjectException, MetaException, InvalidInputException, InvalidObjectException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1570 PS1, Line 1570: throws NoSuchObjectException, InvalidObjectException, MetaException, InvalidInputException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1581 PS1, Line 1581: throws NoSuchObjectException, MetaException, InvalidObjectException, InvalidInputException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1592 PS1, Line 1592: throws NoSuchObjectException, MetaException, InvalidObjectException, InvalidInputException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1602 PS1, Line 1602: throws AlreadyExistsException, InvalidObjectException, MetaException, NoSuchObjectException, TException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2073 PS1, Line 2073: public MaxAllocatedTableWriteIdResponse get_max_allocated_table_write_id(MaxAllocatedTableWriteIdRequest rqst) line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2076 PS1, Line 2076: return client.getHiveClient().getThriftClient().get_max_allocated_table_write_id(rqst); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2286 PS1, Line 2286: throws AlreadyExistsException, NoSuchObjectException, InvalidObjectException, MetaException, TException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2307 PS1, Line 2307: return client.getHiveClient().getThriftClient().drop_wm_trigger(wmDropTriggerRequest); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2323 PS1, Line 2323: throws AlreadyExistsException, NoSuchObjectException, InvalidObjectException, MetaException, TException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2332 PS1, Line 2332: throws AlreadyExistsException, NoSuchObjectException, InvalidObjectException, MetaException, TException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2349 PS1, Line 2349: throws AlreadyExistsException, NoSuchObjectException, InvalidObjectException, MetaException, TException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2366 PS1, Line 2366: public WMCreateOrDropTriggerToPoolMappingResponse create_or_drop_wm_trigger_to_pool_mapping( line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2368 PS1, Line 2368: throws AlreadyExistsException, NoSuchObjectException, InvalidObjectException, MetaException, TException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2420 PS1, Line 2420: return client.getHiveClient().getThriftClient().get_schema_version(schemaVersionDescriptor); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2428 PS1, Line 2428: return client.getHiveClient().getThriftClient().get_schema_latest_version(iSchemaName); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2436 PS1, Line 2436: return client.getHiveClient().getThriftClient().get_schema_all_versions(iSchemaName); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2444 PS1, Line 2444: client.getHiveClient().getThriftClient().drop_schema_version(schemaVersionDescriptor); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2452 PS1, Line 2452: return client.getHiveClient().getThriftClient().get_schemas_by_cols(findSchemasByColsRqst); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2461 PS1, Line 2461: client.getHiveClient().getThriftClient().map_schema_version_to_serde(mapSchemaVersionToSerdeRequest); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2470 PS1, Line 2470: client.getHiveClient().getThriftClient().set_schema_version_state(setSchemaVersionStateRequest); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2494 PS1, Line 2494: return client.getHiveClient().getThriftClient().get_lock_materialization_rebuild(s, s1, l); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2502 PS1, Line 2502: return client.getHiveClient().getThriftClient().heartbeat_lock_materialization_rebuild(s, s1, l); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2518 PS1, Line 2518: return client.getHiveClient().getThriftClient().get_runtime_stats(getRuntimeStatsRequest); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2527 PS1, Line 2527: return client.getHiveClient().getThriftClient().scheduled_query_poll(scheduledQueryPollRequest); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2534 PS1, Line 2534: throws MetaException, NoSuchObjectException, AlreadyExistsException, InvalidInputException, TException { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2536 PS1, Line 2536: client.getHiveClient().getThriftClient().scheduled_query_maintenance(scheduledQueryMaintenanceRequest); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2545 PS1, Line 2545: client.getHiveClient().getThriftClient().scheduled_query_progress(scheduledQueryProgressInfo); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2553 PS1, Line 2553: return client.getHiveClient().getThriftClient().get_scheduled_query(scheduledQueryKey); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2561 PS1, Line 2561: client.getHiveClient().getThriftClient().add_replication_metrics(replicationMetricList); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2566 PS1, Line 2566: public ReplicationMetricList get_replication_metrics(GetReplicationMetricsRequest getReplicationMetricsRequest) line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2569 PS1, Line 2569: return client.getHiveClient().getThriftClient().get_replication_metrics(getReplicationMetricsRequest); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHMSCacheFlagTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHMSCacheFlagTest.java: http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHMSCacheFlagTest.java@25 PS1, Line 25: import static org.apache.impala.catalog.metastore.CatalogHMSFileMetadataTest.assertFdsAreSame; line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17244/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/17244/1/tests/common/impala_test_suite.py@156 PS1, Line 156: @ flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@19 PS1, Line 19: import logging flake8: F401 'logging' imported but unused http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@25 PS1, Line 25: from hive_metastore.ttypes import GetValidWriteIdsRequest flake8: F401 'hive_metastore.ttypes.GetValidWriteIdsRequest' imported but unused http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@230 PS1, Line 230: @ flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@294 PS1, Line 294: " flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@405 PS1, Line 405: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@420 PS1, Line 420: t flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@427 PS1, Line 427: _ flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@430 PS1, Line 430: ) flake8: E501 line too long (92 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/17244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b306f91d63cb5137c178e8e72b6e8b578a907b5 Gerrit-Change-Number: 17244 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 30 Mar 2021 22:40:05 +0000 Gerrit-HasComments: Yes
