Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17244 )
Change subject: IMPALA-10613 : Standup HMS thrift server in Catalog ...................................................................... Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/17244/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17244/3//COMMIT_MSG@7 PS3, Line 7: nit: no whitespace http://gerrit.cloudera.org:8080/#/c/17244/3/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/17244/3/be/src/catalog/catalog-server.cc@94 PS3, Line 94: hms_port_number hms_port http://gerrit.cloudera.org:8080/#/c/17244/3/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/17244/3/be/src/common/global-flags.cc@352 PS3, Line 352: " it will be redirected to HMS."); nit: add a blank line here http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java File fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java: http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@87 PS3, Line 87: CatalogHMSAPIHelper nit: I think our naming rules prefer "CatalogHmsApiHelper" http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@96 PS3, Line 96: maxNonHdfsPartsParallelLoad Should this be maxHdfsPartsParallelLoad(), or we just choose this because it defaults to 20? http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@138 PS3, Line 138: CDPD-14901 File an upstream JIRA for this? http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHMSClientUtils.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHMSClientUtils.java: http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHMSClientUtils.java@46 PS3, Line 46: CatalogHMSClientUtils nit: CatalogHmsClientUtils? http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHMSFileMetadataTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHMSFileMetadataTest.java: http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHMSFileMetadataTest.java@50 PS3, Line 50: CatalogHMSFileMetadataTest nit: CatalogHmsFileMetadataTest? http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHMSCacheFlagTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHMSCacheFlagTest.java: http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHMSCacheFlagTest.java@50 PS3, Line 50: EnableCatalogdHMSCacheFlagTest nit: EnableCatalogdHmsCacheFlagTest? http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java File fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java: http://gerrit.cloudera.org:8080/#/c/17244/3/fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java@67 PS3, Line 67: startHMS nit: startHms? -- To view, visit http://gerrit.cloudera.org:8080/17244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b306f91d63cb5137c178e8e72b6e8b578a907b5 Gerrit-Change-Number: 17244 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 02 Apr 2021 13:33:46 +0000 Gerrit-HasComments: Yes
