Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17244 )

Change subject: IMPALA-10613 : Standup HMS thrift server in Catalog
......................................................................


Patch Set 2:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java
File fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java:

http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@121
PS2, Line 121:     GetPartialCatalogObjectRequestBuilder reqBuilder = new 
GetPartialCatalogObjectRequestBuilder()
line too long (98 > 90)


http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@225
PS2, Line 225:     GetPartialCatalogObjectRequestBuilder catalogReq = new 
GetPartialCatalogObjectRequestBuilder()
line too long (98 > 90)


http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@519
PS2, Line 519:                 + "fallback path. Time taken: {} msec", 
getPartsResult.getPartitionsSize(),
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/CatalogHMSAPIHelper.java@523
PS2, Line 523:                 + "fallback path. Time taken: {} msec", 
getPartsResult.getPartitionsSize(),
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
File 
fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java:

http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1600
PS2, Line 1600:       throws NoSuchObjectException, InvalidObjectException, 
MetaException, InvalidInputException, TException {
line too long (110 > 90)


http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1611
PS2, Line 1611:       throws NoSuchObjectException, MetaException, 
InvalidObjectException, InvalidInputException, TException {
line too long (110 > 90)


http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1622
PS2, Line 1622:       throws NoSuchObjectException, MetaException, 
InvalidObjectException, InvalidInputException, TException {
line too long (110 > 90)


http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1632
PS2, Line 1632:       throws AlreadyExistsException, InvalidObjectException, 
MetaException, NoSuchObjectException, TException {
line too long (111 > 90)


http://gerrit.cloudera.org:8080/#/c/17244/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2403
PS2, Line 2403:   public WMCreateOrDropTriggerToPoolMappingResponse 
create_or_drop_wm_trigger_to_pool_mapping(
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/17244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b306f91d63cb5137c178e8e72b6e8b578a907b5
Gerrit-Change-Number: 17244
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Tue, 30 Mar 2021 23:00:28 +0000
Gerrit-HasComments: Yes

Reply via email to