Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17244 )
Change subject: IMPALA-10613 : Standup HMS thrift server in Catalog ...................................................................... Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3397 PS1, Line 3397: TGetPartialCatalogObjectRequest req, String tableLoadReason) throws CatalogException { > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@745 PS1, Line 745: new ParallelFileMetadataLoader(getFileSystem(), partBuilders, validWriteIds_, validTxnList, > line too long (95 > 90) Done http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@746 PS1, Line 746: Utils.shouldRecursivelyListPartitions(this), getHostIndex(), debugActions, logPrefix) > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java: http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java@199 PS1, Line 199: new Class[]{ThriftHiveMetastore.Iface.class, ICatalogMetastoreServer.class}, > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHMSCacheFlagTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHMSCacheFlagTest.java: http://gerrit.cloudera.org:8080/#/c/17244/1/fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHMSCacheFlagTest.java@25 PS1, Line 25: import static org.apache.impala.catalog.metastore.CatalogHMSFileMetadataTest.assertFdsAreSame; > line too long (94 > 90) Done http://gerrit.cloudera.org:8080/#/c/17244/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/17244/1/tests/common/impala_test_suite.py@156 PS1, Line 156: @ > flake8: E303 too many blank lines (2) Done http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@19 PS1, Line 19: import logging > flake8: F401 'logging' imported but unused Done http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@25 PS1, Line 25: from hive_metastore.ttypes import GetValidWriteIdsRequest > flake8: F401 'hive_metastore.ttypes.GetValidWriteIdsRequest' imported but u Done http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@230 PS1, Line 230: @ > flake8: E303 too many blank lines (2) Done http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@294 PS1, Line 294: " > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@405 PS1, Line 405: # > flake8: E265 block comment should start with '# ' Done http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@420 PS1, Line 420: t > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@427 PS1, Line 427: _ > flake8: E501 line too long (96 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/17244/1/tests/custom_cluster/test_metastore_service.py@430 PS1, Line 430: ) > flake8: E501 line too long (92 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/17244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b306f91d63cb5137c178e8e72b6e8b578a907b5 Gerrit-Change-Number: 17244 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 30 Mar 2021 22:59:21 +0000 Gerrit-HasComments: Yes
