Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17756 )
Change subject: [WIP]: Initial commit: Add logic to sync to latest event id ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@237 PS3, Line 237: List<SQLForeignKey> sqlForeignKeys, List<SQLUniqueConstraint> sqlUniqueConstraints, line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@238 PS3, Line 238: List<SQLNotNullConstraint> sqlNotNullConstraints, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@239 PS3, Line 239: List<SQLDefaultConstraint> sqlDefaultConstraints, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@710 PS3, Line 710: Preconditions.checkState(syncToLatestEventId_, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2503 PS3, Line 2503: private static void createTable(MetaStoreClient msClient, String catName, String dbName, String tblName, line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3032 PS3, Line 3032: private static void createTable(MetaStoreClient msClient, String tblName, boolean isPartitioned) line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java: http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@18 PS3, Line 18: try (MetaStoreClientPool.MetaStoreClient msClient = catalog_.getMetaStoreClient()) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17756/3/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@45 PS3, Line 45: try (MetaStoreClientPool.MetaStoreClient msClient = catalog_.getMetaStoreClient()) { line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia822d15725d0a9a9ad1398e10ed4ae3288d0e9ad Gerrit-Change-Number: 17756 Gerrit-PatchSet: 3 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 09 Aug 2021 16:36:07 +0000 Gerrit-HasComments: Yes
