Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17756 )
Change subject: [WIP]: Initial commit: Add logic to sync to latest event id ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/17756/4/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17756/4/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@237 PS4, Line 237: List<SQLForeignKey> sqlForeignKeys, List<SQLUniqueConstraint> sqlUniqueConstraints, line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/17756/4/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@238 PS4, Line 238: List<SQLNotNullConstraint> sqlNotNullConstraints, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/4/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@239 PS4, Line 239: List<SQLDefaultConstraint> sqlDefaultConstraints, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/4/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@383 PS4, Line 383: boolean response = super.drop_partition_by_name(dbname, tblname, partName, deleteData); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/4/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@731 PS4, Line 731: Preconditions.checkState(syncToLatestEventId_, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17756/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/17756/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2499 PS4, Line 2499: String tblName, Map<String, String> params, boolean isPartitioned) throws TException { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17756/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3181 PS4, Line 3181: public static void addPartitions(MetaStoreClient msClient, String dbName, String tblName, line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia822d15725d0a9a9ad1398e10ed4ae3288d0e9ad Gerrit-Change-Number: 17756 Gerrit-PatchSet: 4 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 10 Aug 2021 14:10:04 +0000 Gerrit-HasComments: Yes
