Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/18038 )
Change subject: IMPALA-11028: Table loading can fail when events are cleaned up ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18038/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/18038/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@583 PS5, Line 583: * Gets metastore notification events from the given eventId. The returned list of nit: since this method is directly referencing the event processor's api, do the comments for this method above need to be updated ? This is now more like a wrapper function. -- To view, visit http://gerrit.cloudera.org:8080/18038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95e5e20e1a2086688a92abdfb28e89177e996a1a Gerrit-Change-Number: 18038 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Comment-Date: Sun, 21 Nov 2021 04:44:01 +0000 Gerrit-HasComments: Yes
