Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/18038 )
Change subject: IMPALA-11028: Table loading can fail when events are cleaned up ...................................................................... Patch Set 7: Code-Review+2 (2 comments) A minor comment about logging. Feel free to carry forward the +2 once you address it. http://gerrit.cloudera.org:8080/#/c/18038/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/18038/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@586 PS7, Line 586: getAllEvents Yes, this name is more intuitive and accurate. http://gerrit.cloudera.org:8080/#/c/18038/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@621 PS7, Line 621: LOG.info(String.format("Received %d events. Start event id : %d", A minor change in logging behavior: previously the log message was showing the filtered events. This one shows the unfiltered events. It might be useful to also log the filtered ones. -- To view, visit http://gerrit.cloudera.org:8080/18038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95e5e20e1a2086688a92abdfb28e89177e996a1a Gerrit-Change-Number: 18038 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 22 Nov 2021 06:57:58 +0000 Gerrit-HasComments: Yes
