Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18038 )
Change subject: IMPALA-11028: Table loading can fail when events are cleaned up ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18038/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/18038/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@583 PS5, Line 583: * NotificationEvents are filtered using the NotificationFilter provided if it is not > nit: since this method is directly referencing the event processor's api, Actually, I realized that my patch changed the behavior of this method. This method actually uses skipBatching flag to either get all the events since eventId or just the next 1000 events since eventId depending on the value of the skipBatching flag. I have renamed the method and the variable name to make it more clear. -- To view, visit http://gerrit.cloudera.org:8080/18038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95e5e20e1a2086688a92abdfb28e89177e996a1a Gerrit-Change-Number: 18038 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 22 Nov 2021 05:11:24 +0000 Gerrit-HasComments: Yes
