Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/18038 )
Change subject: IMPALA-11028: Table loading can fail when events are cleaned up ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18038/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/18038/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@586 PS7, Line 586: * @param getAllEvents If this is true all the events since eventId are returned. @Vihang: Looks like setting getAllEvents to true is *not* sufficient to get all events since eventId. It is because HMSHandler has a property metastore.max.event.response which decides the max number of events returned by HMS in a single api call. Though the default value of the property is 1M which is fairly large but the above semantics would break for a customer who has set this property value to few thousands. -- To view, visit http://gerrit.cloudera.org:8080/18038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95e5e20e1a2086688a92abdfb28e89177e996a1a Gerrit-Change-Number: 18038 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Nov 2021 11:30:59 +0000 Gerrit-HasComments: Yes
