Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18661 )
Change subject: IMPALA-11384: Upgrade CPP thrift components to thrift-0.16.0 ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18661/1/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18661/1/be/src/runtime/io/disk-io-mgr.cc@a63 PS1, Line 63: Is the change necessary for this patch? http://gerrit.cloudera.org:8080/#/c/18661/1/be/src/util/process-state-info.cc File be/src/util/process-state-info.cc: http://gerrit.cloudera.org:8080/#/c/18661/1/be/src/util/process-state-info.cc@a40 PS1, Line 40: Same with the other comment. -- To view, visit http://gerrit.cloudera.org:8080/18661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic278ac5c973ff5c3e829a6139b9c16e9d2c62a59 Gerrit-Change-Number: 18661 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 23 Jun 2022 15:42:39 +0000 Gerrit-HasComments: Yes
