Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18661 )
Change subject: IMPALA-11384: Upgrade CPP thrift components to thrift-0.16.0 ...................................................................... Patch Set 2: > Patch Set 2: > > Build Failed > > https://jenkins.impala.io/job/gerrit-code-review-checks/10851/ : Initial code > review checks failed. See linked job for details on the failure. clang tidy complains about missing override keyword. I can fix it manually using sed against generated code like this: sed -i 's/\(dispatchCallTemplated.*\)callContext)/\1callContext) override/' ImpalaHiveServer2Service.h However, I haven't find a good way to hook it up in common/thrift/CMakeLists.txt. -- To view, visit http://gerrit.cloudera.org:8080/18661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic278ac5c973ff5c3e829a6139b9c16e9d2c62a59 Gerrit-Change-Number: 18661 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 23 Jun 2022 18:26:05 +0000 Gerrit-HasComments: No
