Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18661 )
Change subject: IMPALA-11384: Upgrade CPP thrift components to thrift-0.16.0 ...................................................................... Patch Set 1: Code-Review+1 (2 comments) lgtm! http://gerrit.cloudera.org:8080/#/c/18661/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18661/1//COMMIT_MSG@15 PS1, Line 15: adjust nit: adjusts http://gerrit.cloudera.org:8080/#/c/18661/1/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18661/1/be/src/runtime/io/disk-io-mgr.cc@a63 PS1, Line 63: > Not sure why, but I got errors like this if I don't remove this line. Looks the new version thrift would generate to_string functions in the headers while the old doesn't have them. -- To view, visit http://gerrit.cloudera.org:8080/18661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic278ac5c973ff5c3e829a6139b9c16e9d2c62a59 Gerrit-Change-Number: 18661 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 23 Jun 2022 17:02:47 +0000 Gerrit-HasComments: Yes
