Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18661 )
Change subject: IMPALA-11384: Upgrade CPP thrift components to thrift-0.16.0 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18661/1/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18661/1/be/src/runtime/io/disk-io-mgr.cc@a63 PS1, Line 63: > Is the change necessary for this patch? Not sure why, but I got errors like this if I don't remove this line. /home/systest/workspace/impala/be/generated-sources/gen-cpp/CatalogObjects_types.h:198:13: note: candidate: std::__cxx11::string impala::to_string(const imp ala::TTablePropertyType::type&) <near match> std::string to_string(const TTablePropertyType::type& val); ^~~~~~~~~ /home/systest/workspace/impala/be/generated-sources/gen-cpp/CatalogObjects_types.h:198:13: note: conversion of argument 1 would be ill-formed: /home/systest/workspace/impala/be/src/runtime/io/disk-io-mgr.cc:505:77: error: invalid conversion from ‘int’ to ‘impala::TTablePropertyType::type’ [-fpermis sive] i < DiskInfo::num_disks() ? DiskInfo::device_name(i) : to_string(i); ^ In file included from /home/systest/workspace/impala/be/src/util/error-util.h:26:0, from /home/systest/workspace/impala/be/src/common/status.h:31, from /home/systest/workspace/impala/be/src/runtime/io/disk-io-mgr.h:29, from /home/systest/workspace/impala/be/src/runtime/io/disk-io-mgr.cc:18: -- To view, visit http://gerrit.cloudera.org:8080/18661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic278ac5c973ff5c3e829a6139b9c16e9d2c62a59 Gerrit-Change-Number: 18661 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 23 Jun 2022 15:51:55 +0000 Gerrit-HasComments: Yes
