[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 )
Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables ...................................................................... Patch Set 4: Code-Review+1 (6 comments) LGTM! Just left a few minor comments. http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@559 PS4, Line 559: dataFiles nit: This is a pair of List<DataFile> and Set<DeleteFile>, maybe we should rename it. http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@129 PS4, Line 129: 2147483545 Just want to know: where does this number come from? http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@35 PS4, Line 35: import org.apache.impala.catalog.IcebergColumn; : import org.apache.impala.catalog.IcebergTable; nit: It may be unnecessary. http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@39 PS4, Line 39: import org.apache.impala.catalog.Type; ditto. http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java: http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@48 PS4, Line 48: import org.apache.impala.catalog.Type; nit: it may be unnecessary. http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/18847/4/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@93 PS4, Line 93: TimeTravelSpec nit: should be IcebergScanPlanner. -- To view, visit http://gerrit.cloudera.org:8080/18847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672cfee18d8e131772d90378d5b12ad4d0f7dd48 Gerrit-Change-Number: 18847 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 23 Aug 2022 03:59:59 +0000 Gerrit-HasComments: Yes
