Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 )
Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables ...................................................................... Patch Set 5: (17 comments) Great change! Added some minor comments and will try to do another round in the afternoon. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@106 PS5, Line 106: nit: is this our preferred indentation for longer loops? http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java File fe/src/main/java/org/apache/impala/catalog/VirtualTable.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java@25 PS5, Line 25: import java.util.Set; Unused import. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java@34 PS5, Line 34: import org.apache.impala.thrift.TResultSet; : import org.apache.impala.thrift.TIcebergPartitionStats; Unused import. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java@37 PS5, Line 37: import org.apache.impala.thrift.TTableStats; Unused import. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@35 PS5, Line 35: import org.apache.impala.catalog.IcebergColumn; : import org.apache.impala.catalog.IcebergTable; Unused import. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@39 PS5, Line 39: import org.apache.impala.catalog.VirtualColumn; Unused import. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@1 PS5, Line 1: nit: empty line http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@35 PS5, Line 35: import org.apache.iceberg.DataFile; Unused import. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@88 PS5, Line 88: import com.google.common.collect.Iterables; Unused import. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@117 PS5, Line 117: getIceTable Shouldn't this getter be next to the others? http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@133 PS5, Line 133: feFsTable Unused variable. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@181 PS5, Line 181: ALIAS_COUNTER We could use the PlanNodeId here as well, it would not grow across query executions. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@198 PS5, Line 198: operator nit: node http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@212 PS5, Line 212: feTable Unused variable. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@227 PS5, Line 227: feTable Unused variable. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@232 PS5, Line 232: nit: indentation. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@278 PS5, Line 278: fileDescList Unused variable. -- To view, visit http://gerrit.cloudera.org:8080/18847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672cfee18d8e131772d90378d5b12ad4d0f7dd48 Gerrit-Change-Number: 18847 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 26 Aug 2022 10:02:32 +0000 Gerrit-HasComments: Yes
