Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 )
Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables ...................................................................... Patch Set 5: (21 comments) Thanks for the comments, Tamas! http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@106 PS5, Line 106: > nit: is this our preferred indentation for longer loops? I just found it easier to be read, i.e. it makes it clear what are the arguments of the concat(). I don't know how strict our formatting rules are, I guess we can deviate from it when needed. But I can change it if you think it makes the code harder to read because of inconsistent indentation. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@728 PS5, Line 728: > nit: empty line Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/IcebergPositionDeleteTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergPositionDeleteTable.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/IcebergPositionDeleteTable.java@71 PS5, Line 71: true > I could not find any reference, but I believe this column cannot be null. Good catch, done. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java File fe/src/main/java/org/apache/impala/catalog/VirtualTable.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java@25 PS5, Line 25: import java.util.Set; > Unused import. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java@34 PS5, Line 34: import org.apache.impala.thrift.TResultSet; : import org.apache.impala.thrift.TIcebergPartitionStats; > Unused import. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java@37 PS5, Line 37: import org.apache.impala.thrift.TTableStats; > Unused import. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java@79 PS5, Line 79: @Override : public String getTableComment() { return null; } : : @Override : public boolean isLoaded() { : return true; : } > nit: different short method format styles in this file. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@35 PS5, Line 35: import org.apache.impala.catalog.IcebergColumn; : import org.apache.impala.catalog.IcebergTable; > Unused import. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@39 PS5, Line 39: import org.apache.impala.catalog.VirtualColumn; > Unused import. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java File fe/src/main/java/org/apache/impala/planner/HashJoinNode.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@178 PS5, Line 178: if (!isDeleteRowsJoin_ || detailLevel.ordinal() >= TExplainLevel.EXTENDED.ordinal()) { > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@1 PS5, Line 1: > nit: empty line Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@35 PS5, Line 35: import org.apache.iceberg.DataFile; > Unused import. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@88 PS5, Line 88: import com.google.common.collect.Iterables; > Unused import. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@117 PS5, Line 117: getIceTable > Shouldn't this getter be next to the others? Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@133 PS5, Line 133: feFsTable > Unused variable. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@181 PS5, Line 181: ALIAS_COUNTER > We could use the PlanNodeId here as well, it would not grow across query ex Good idea, thanks! http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@198 PS5, Line 198: operator > nit: node Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@212 PS5, Line 212: feTable > Unused variable. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@227 PS5, Line 227: feTable > Unused variable. Done http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@232 PS5, Line 232: > nit: indentation. It'd rather keep it this way for readability. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@278 PS5, Line 278: fileDescList > Unused variable. Done -- To view, visit http://gerrit.cloudera.org:8080/18847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672cfee18d8e131772d90378d5b12ad4d0f7dd48 Gerrit-Change-Number: 18847 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 26 Aug 2022 13:39:01 +0000 Gerrit-HasComments: Yes
