Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 )
Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@728 PS5, Line 728: nit: empty line http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/IcebergPositionDeleteTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergPositionDeleteTable.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/IcebergPositionDeleteTable.java@71 PS5, Line 71: true I could not find any reference, but I believe this column cannot be null. http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java File fe/src/main/java/org/apache/impala/catalog/VirtualTable.java: http://gerrit.cloudera.org:8080/#/c/18847/5/fe/src/main/java/org/apache/impala/catalog/VirtualTable.java@79 PS5, Line 79: @Override : public String getTableComment() { return null; } : : @Override : public boolean isLoaded() { : return true; : } nit: different short method format styles in this file. -- To view, visit http://gerrit.cloudera.org:8080/18847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672cfee18d8e131772d90378d5b12ad4d0f7dd48 Gerrit-Change-Number: 18847 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 26 Aug 2022 12:39:45 +0000 Gerrit-HasComments: Yes
