Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19083 )
Change subject: IMPALA-11623: Put *-ir.cc files into their own libraries to avoid extra recompilation ...................................................................... Patch Set 3: (1 comment) This is looking good. Just a minor comment about gen_ir_descriptions. http://gerrit.cloudera.org:8080/#/c/19083/3/be/src/exprs/CMakeLists.txt File be/src/exprs/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19083/3/be/src/exprs/CMakeLists.txt@85 PS3, Line 85: # TODO: Should we depend on gen_ir_descriptions? To answer this, you can look at what files are being generated by gen_ir_descriptions. I see that here: https://github.com/apache/impala/blob/master/be/src/codegen/gen_ir_descriptions.py#L37-L41 It looks like it generates impala-ir-functions.h and impala-ir-names.h. You can use git grep to see what files include that. I see that impala-ir-functions.h is included by scalar-expr.h, expr.h, min-max-filter.h, in-list-filter.h. You can grep for references to those header files. My read on this is that Exec, Exprs, Runtime, Service, and Util should have gen_ir_descriptions as a dependency (along with some of the *Ir libraries). A couple of those might be missing today. My guess is that there is some way for CMake to handle this automatically, but that can be future work. -- To view, visit http://gerrit.cloudera.org:8080/19083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63b9285bac6494a19f614d0ebc694a91bdf7a8a0 Gerrit-Change-Number: 19083 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Wed, 05 Oct 2022 17:12:32 +0000 Gerrit-HasComments: Yes
