Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19083 )
Change subject: IMPALA-11623: Put *-ir.cc files into their own libraries to avoid extra recompilation ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19083/3/be/src/exprs/CMakeLists.txt File be/src/exprs/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19083/3/be/src/exprs/CMakeLists.txt@85 PS3, Line 85: # TODO: Should we depend on gen_ir_descriptions? > To answer this, you can look at what files are being generated by gen_ir_de The headers that include the generated ir description files are indeed scalar-expr.h, expr.h, min-max-filter.h, in-list-filter.h, and also llvm-codegen.h. So these are files from the directories codegen, exprs and util. Should we also add gen_ir_descriptions as a dependency for other targets that include these headers? I'm not even sure it's necessary to add this dependency at all, even targets that didn't have this dependency were recompiled when I modified gen_ir_descriptions.py. It may be because it only generates headers, and CMake follows headers automatically and recompiles source files when an included header changes. -- To view, visit http://gerrit.cloudera.org:8080/19083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63b9285bac6494a19f614d0ebc694a91bdf7a8a0 Gerrit-Change-Number: 19083 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Fri, 07 Oct 2022 14:27:09 +0000 Gerrit-HasComments: Yes
