Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19083 )
Change subject: IMPALA-11623: Put *-ir.cc files into their own libraries to avoid extra recompilation ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19083/3/be/src/exprs/CMakeLists.txt File be/src/exprs/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19083/3/be/src/exprs/CMakeLists.txt@85 PS3, Line 85: add_dependencies(Exprs gen-deps gen_ir_descripti > I experimented with removing the references to gen_ir_descriptions across t I added gen_ir_descriptions to UtilIr. So now of the targets that have an *Ir only Exec, ExecAvro and ExecKudu don't have gen_ir_descriptions as a dependency (the target and its *Ir also). Do you think I should add the dependency to be on the safe side or should we leave it at that? -- To view, visit http://gerrit.cloudera.org:8080/19083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63b9285bac6494a19f614d0ebc694a91bdf7a8a0 Gerrit-Change-Number: 19083 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Wed, 12 Oct 2022 07:25:02 +0000 Gerrit-HasComments: Yes
