Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19083 )
Change subject: IMPALA-11623: Put *-ir.cc files into their own libraries to avoid extra recompilation ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19083/3/be/src/exprs/CMakeLists.txt File be/src/exprs/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19083/3/be/src/exprs/CMakeLists.txt@85 PS3, Line 85: # TODO: Should we depend on gen_ir_descriptions? > I added gen_ir_descriptions to UtilIr. I've been thinking about this. gen_ir_descriptions is a very fast target. If we added it as a dependency for gen-deps, it wouldn't delay anything, and gen-deps is listed as a dependency on everything we care about. It's a superset, but that doesn't harm the build. That might be a simpler solution than worrying about labeling everything perfectly. Adding a sleep to gen_ir_descriptions.py unearths all the dependency problems. I added a 120 second sleep and all sorts of files fail. Basically, if the dependencies are right, then nothing fails and the sleep just delays the build. To have this exactly right means adding gen_ir_descriptions to Runtime, Exec, ExecAvro, ExecParquet, ExecKudu, Service, and a bunch more. It's extremely pervasive. So, let's incorporate it into gen-deps. -- To view, visit http://gerrit.cloudera.org:8080/19083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63b9285bac6494a19f614d0ebc694a91bdf7a8a0 Gerrit-Change-Number: 19083 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Fri, 14 Oct 2022 01:05:30 +0000 Gerrit-HasComments: Yes
