Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19279 )
Change subject: IMPALA-11744: Table mask view should reserve the original column order in Hive ...................................................................... Patch Set 1: (4 comments) Looks very good. Just have some minor comments. I also wonder if the scope of the problem is with column masking views only or not. Can you please double check? http://gerrit.cloudera.org:8080/#/c/19279/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19279/1//COMMIT_MSG@21 PS1, Line 21: tbl nit. tbl; http://gerrit.cloudera.org:8080/#/c/19279/1//COMMIT_MSG@22 PS1, Line 22: to be nit. with Ideally Impala should replace the TableRef of 'tbl' with a table mask view as: http://gerrit.cloudera.org:8080/#/c/19279/1//COMMIT_MSG@31 PS1, Line 31: makes STAR be expanded nit. This incorrectly expands the STAR as "b, a, c" ... http://gerrit.cloudera.org:8080/#/c/19279/1/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java File fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java: http://gerrit.cloudera.org:8080/#/c/19279/1/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@560 PS1, Line 560: Hive nit. May add a comment here to indicate the Hive order is the logically defined order. -- To view, visit http://gerrit.cloudera.org:8080/19279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic83d78312b19fa2c5ab88ac4f359bfabaeaabce6 Gerrit-Change-Number: 19279 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Sat, 26 Nov 2022 03:27:00 +0000 Gerrit-HasComments: Yes
