Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19279 )
Change subject: IMPALA-11744: Table mask view should reserve the original column order in Hive ...................................................................... Patch Set 2: (3 comments) Thank Qifan and Fang-Yu! Resolved the comments. http://gerrit.cloudera.org:8080/#/c/19279/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19279/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@941 PS2, Line 941: List<Column> columns = resolvedTableRef.getSelectedColumnsInHiveOrder(); > Could we add a code comment here to point out that the selected columns sho Done http://gerrit.cloudera.org:8080/#/c/19279/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1611 PS2, Line 1611: Register scalar columns. Used in resolving column mask. > Could we also add a code comment here to point out that the order in which Done http://gerrit.cloudera.org:8080/#/c/19279/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/19279/2/fe/src/main/java/org/apache/impala/analysis/TableRef.java@793 PS2, Line 793: reserve > nit: preserve Done -- To view, visit http://gerrit.cloudera.org:8080/19279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic83d78312b19fa2c5ab88ac4f359bfabaeaabce6 Gerrit-Change-Number: 19279 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 28 Nov 2022 09:55:37 +0000 Gerrit-HasComments: Yes
