Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19279 )
Change subject: IMPALA-11744: Table mask view should reserve the original column order in Hive ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19279/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19279/3//COMMIT_MSG@7 PS3, Line 7: reserve Nit: preserve? http://gerrit.cloudera.org:8080/#/c/19279/3/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/19279/3/fe/src/main/java/org/apache/impala/analysis/TableRef.java@794 PS3, Line 794: Map<String, Column> colSelection = new LinkedHashMap<>(); Instead of using 'colSelection' as an intermediary structure, would it be possible to - iterate through getColumnsInHiveOrder() - check if there is a match in 'columns_' for c.getName() - if there is a (non-null) match, add it to the 'res' list? Or are there columns that are in 'columns_' but not in getColumnsInHiveOrder()? -- To view, visit http://gerrit.cloudera.org:8080/19279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic83d78312b19fa2c5ab88ac4f359bfabaeaabce6 Gerrit-Change-Number: 19279 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:44:52 +0000 Gerrit-HasComments: Yes
