Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 )
Change subject: IMPALA-11717: Use rapidjson for printing collections ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/19309/6/be/src/runtime/complex-value-writer.cc File be/src/runtime/complex-value-writer.cc: http://gerrit.cloudera.org:8080/#/c/19309/6/be/src/runtime/complex-value-writer.cc@49 PS6, Line 49: else if (type.IsBooleanType() && !map_key) { : writer->Bool( *(reinterpret_cast<bool*>(value)) ); This branch could return before calling PrintValue. http://gerrit.cloudera.org:8080/#/c/19309/6/be/src/service/query-result-set.cc File be/src/service/query-result-set.cc: http://gerrit.cloudera.org:8080/#/c/19309/6/be/src/service/query-result-set.cc@238 PS6, Line 238: scale I don't think that we really need to pass scale - this probably comes from a misunderstanding during array implementation by me / Attila Jeges. According to https://github.com/apache/impala/blob/master/be/src/exprs/scalar-expr-evaluator.h#L201 output scale is only set to non -1 in RoundUpTo(), which makes it irrelevant for complex types. So my guess is that always passing -1 or removing it wouldn't break any tests. I think that we should have the same handling in HS2 and Beeswax, so either: a. always use default scale in both protocols b. add a way to configure this I would vote for a. and adding a config only if someone requests it. -- To view, visit http://gerrit.cloudera.org:8080/19309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08a2d596a498fbbaf1419b18284846b992f49165 Gerrit-Change-Number: 19309 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 12 Dec 2022 22:11:42 +0000 Gerrit-HasComments: Yes
