Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 )
Change subject: IMPALA-11717: Use rapidjson for printing collections ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19309/6/be/src/runtime/complex-value-writer.cc File be/src/runtime/complex-value-writer.cc: http://gerrit.cloudera.org:8080/#/c/19309/6/be/src/runtime/complex-value-writer.cc@49 PS6, Line 49: tring tmp; : RawValue::PrintValue(value, type, -1, &tmp); > This branch could return before calling PrintValue. Done http://gerrit.cloudera.org:8080/#/c/19309/6/be/src/service/query-result-set.cc File be/src/service/query-result-set.cc: http://gerrit.cloudera.org:8080/#/c/19309/6/be/src/service/query-result-set.cc@238 PS6, Line 238: > I don't think that we really need to pass scale - this probably comes from Removed the 'scale' parameter from the functions. -- To view, visit http://gerrit.cloudera.org:8080/19309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08a2d596a498fbbaf1419b18284846b992f49165 Gerrit-Change-Number: 19309 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 13 Dec 2022 09:54:48 +0000 Gerrit-HasComments: Yes
