Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 )
Change subject: IMPALA-11717: Use rapidjson for printing collections ...................................................................... Patch Set 7: Code-Review+1 (2 comments) Added a few nitpicks, but generally LGTM! http://gerrit.cloudera.org:8080/#/c/19309/7/be/src/runtime/complex-value-writer.h File be/src/runtime/complex-value-writer.h: http://gerrit.cloudera.org:8080/#/c/19309/7/be/src/runtime/complex-value-writer.h@35 PS7, Line 35: // rapidjson::BasicOStreamWrapper<std::stringstream>, the class template is explicitly : // instantiated for these types. nit: putting the implementation into a *.inline.h would prevent the need of explicit instantiation and the user could just include the implementation if needed. As I understand this is our preferred way based on the style guide, but it has to be noted it is a pivot from the Google C++ Style Guide. http://gerrit.cloudera.org:8080/#/c/19309/7/be/src/runtime/complex-value-writer.cc File be/src/runtime/complex-value-writer.cc: http://gerrit.cloudera.org:8080/#/c/19309/7/be/src/runtime/complex-value-writer.cc@50 PS7, Line 50: -1 Please add this as a const class member and give it some comments why we are passing -1 -- To view, visit http://gerrit.cloudera.org:8080/19309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08a2d596a498fbbaf1419b18284846b992f49165 Gerrit-Change-Number: 19309 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 13 Dec 2022 09:57:09 +0000 Gerrit-HasComments: Yes
